-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add unit test for seata-tm module #1817
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1817 +/- ##
=============================================
+ Coverage 55% 55.37% +0.36%
- Complexity 2361 2378 +17
=============================================
Files 422 422
Lines 14314 14314
Branches 1716 1716
=============================================
+ Hits 7874 7926 +52
+ Misses 5709 5654 -55
- Partials 731 734 +3
|
Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.I left some comments.
tm/src/test/java/io/seata/tm/api/GlobalTransactionContextTest.java
Outdated
Show resolved
Hide resolved
tm/src/test/java/io/seata/tm/api/GlobalTransactionContextTest.java
Outdated
Show resolved
Hide resolved
tm/src/test/java/io/seata/tm/api/GlobalTransactionContextTest.java
Outdated
Show resolved
Hide resolved
tm/src/test/java/io/seata/tm/api/DefaultGlobalTransactionTest.java
Outdated
Show resolved
Hide resolved
tm/src/test/java/io/seata/tm/api/DefaultGlobalTransactionTest.java
Outdated
Show resolved
Hide resolved
tm/src/test/java/io/seata/tm/api/DefaultGlobalTransactionTest.java
Outdated
Show resolved
Hide resolved
tm/src/test/java/io/seata/tm/api/DefaultFailureHandlerImplTest.java
Outdated
Show resolved
Hide resolved
tm/src/test/java/io/seata/tm/api/DefaultFailureHandlerImplTest.java
Outdated
Show resolved
Hide resolved
tm/src/test/java/io/seata/tm/api/DefaultFailureHandlerImplTest.java
Outdated
Show resolved
Hide resolved
tm/src/test/java/io/seata/tm/api/DefaultFailureHandlerImplTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
tm/src/test/java/io/seata/tm/api/DefaultFailureHandlerImplTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@wangwei-ying thank you very much. |
Ⅰ. Describe what this PR did
test: Add unit test to seata-tm module
Ⅱ. Does this pull request fix one issue?
#194
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews