Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add unit test for seata-tm module #1817

Merged
merged 9 commits into from
Nov 1, 2019
Merged

test: Add unit test for seata-tm module #1817

merged 9 commits into from
Nov 1, 2019

Conversation

wangwei-ying
Copy link
Contributor

Ⅰ. Describe what this PR did

test: Add unit test to seata-tm module

Ⅱ. Does this pull request fix one issue?

#194

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Oct 24, 2019

Codecov Report

Merging #1817 into develop will increase coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1817      +/-   ##
=============================================
+ Coverage         55%   55.37%   +0.36%     
- Complexity      2361     2378      +17     
=============================================
  Files            422      422              
  Lines          14314    14314              
  Branches        1716     1716              
=============================================
+ Hits            7874     7926      +52     
+ Misses          5709     5654      -55     
- Partials         731      734       +3
Impacted Files Coverage Δ Complexity Δ
...server/store/file/FileTransactionStoreManager.java 59.21% <0%> (-0.99%) 29% <0%> (ø)
...va/io/seata/tm/api/transaction/NoRollbackRule.java 100% <0%> (+12.5%) 6% <0%> (+1%) ⬆️
...ata/tm/api/transaction/TransactionHookManager.java 80% <0%> (+13.33%) 6% <0%> (+1%) ⬆️
...ain/java/io/seata/tm/TransactionManagerHolder.java 84.61% <0%> (+15.38%) 4% <0%> (+1%) ⬆️
...java/io/seata/tm/api/transaction/RollbackRule.java 100% <0%> (+17.85%) 15% <0%> (+3%) ⬆️
...java/io/seata/tm/api/DefaultGlobalTransaction.java 70.96% <0%> (+19.35%) 19% <0%> (+4%) ⬆️
...java/io/seata/tm/api/GlobalTransactionContext.java 100% <0%> (+23.07%) 6% <0%> (+1%) ⬆️
...ava/io/seata/tm/api/DefaultFailureHandlerImpl.java 72.72% <0%> (+72.72%) 6% <0%> (+6%) ⬆️

@zjinlei zjinlei added the first-time contributor first-time contributor label Oct 24, 2019
@zjinlei
Copy link
Contributor

zjinlei commented Oct 24, 2019

Thanks

@xingfudeshi xingfudeshi self-requested a review October 28, 2019 03:16
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.I left some comments.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title test: Add unit test to seata-tm module test: Add unit test for seata-tm module Nov 1, 2019
@slievrly
Copy link
Member

slievrly commented Nov 1, 2019

@wangwei-ying thank you very much.

@slievrly slievrly merged commit b4bb261 into apache:develop Nov 1, 2019
@slievrly slievrly added this to the 1.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants