Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: global status inconsistent when rollback and branch register … #1825

Merged

Conversation

zjinlei
Copy link
Contributor

@zjinlei zjinlei commented Oct 27, 2019

…are concurrent on db mode

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #1812

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@zjinlei zjinlei added this to the 1.0 milestone Oct 27, 2019
@codecov-io
Copy link

codecov-io commented Oct 27, 2019

Codecov Report

Merging #1825 into develop will decrease coverage by 0.01%.
The diff coverage is 70%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1825      +/-   ##
=============================================
- Coverage      55.34%   55.33%   -0.02%     
+ Complexity      2382     2381       -1     
=============================================
  Files            423      423              
  Lines          14270    14273       +3     
  Branches        1693     1694       +1     
=============================================
  Hits            7898     7898              
- Misses          5662     5663       +1     
- Partials         710      712       +2
Impacted Files Coverage Δ Complexity Δ
...rver/store/db/DatabaseTransactionStoreManager.java 65.9% <100%> (-0.26%) 22 <0> (ø)
.../java/io/seata/server/coordinator/DefaultCore.java 42.41% <25%> (-0.28%) 26 <0> (ø)
...in/java/io/seata/server/session/GlobalSession.java 84.54% <0%> (-0.49%) 67% <0%> (-1%)
...o/seata/server/coordinator/DefaultCoordinator.java 48.01% <0%> (-0.4%) 27% <0%> (-1%)
...server/store/file/FileTransactionStoreManager.java 58.54% <0%> (+0.63%) 30% <0%> (+1%) ⬆️

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zjinlei zjinlei requested a review from slievrly November 3, 2019 09:18
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 8edb5b8 into apache:develop Nov 11, 2019
@zjinlei zjinlei deleted the bugfix/db-rollback-globalstatus-inconsistent branch November 11, 2019 10:51
@ymwangzq
Copy link

Dose doGlobalCommit have the same problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OrderServer rollback,but StorageServer no rollback
5 participants