Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: StateInstance log can't record output parameters #1834

Merged
merged 57 commits into from
Nov 1, 2019

Conversation

long187
Copy link
Contributor

@long187 long187 commented Oct 29, 2019

Ⅰ. Describe what this PR did

Saga: Fix StateInstance log cannot record output parameters

Ⅱ. Does this pull request fix one issue?

#1821

lorne.cl and others added 30 commits September 3, 2019 16:17
@codecov-io
Copy link

codecov-io commented Oct 29, 2019

Codecov Report

Merging #1834 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #1834      +/-   ##
============================================
- Coverage      55.12%   55.1%   -0.03%     
  Complexity      2359    2359              
============================================
  Files            422     422              
  Lines          14281   14281              
  Branches        1712    1712              
============================================
- Hits            7872    7869       -3     
- Misses          5681    5683       +2     
- Partials         728     729       +1
Impacted Files Coverage Δ Complexity Δ
...server/store/file/FileTransactionStoreManager.java 59.21% <0%> (-0.99%) 29% <0%> (ø)

@slievrly slievrly changed the title Saga: Fix StateInstance log cannot record output parameters bugfix: StateInstance log cannot record output parameters Oct 31, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title bugfix: StateInstance log cannot record output parameters bugfix: StateInstance log can't record output parameters Oct 31, 2019
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 1d2f235 into apache:develop Nov 1, 2019
@slievrly slievrly added this to the 1.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants