Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: SagaTransactionalTemplate provide reloadTransaction method #1835

Merged
merged 57 commits into from
Nov 1, 2019

Conversation

long187
Copy link
Contributor

@long187 long187 commented Oct 29, 2019

Ⅰ. Describe what this PR did

SagaTransactionalTemplate.java provide reloadTransaction method

Ⅱ. Does this pull request fix one issue?

#1826

lorne.cl and others added 30 commits September 3, 2019 16:17
@codecov-io
Copy link

codecov-io commented Oct 29, 2019

Codecov Report

Merging #1835 into develop will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1835      +/-   ##
=============================================
+ Coverage      55.08%   55.12%   +0.03%     
- Complexity      2357     2358       +1     
=============================================
  Files            422      422              
  Lines          14281    14281              
  Branches        1712     1712              
=============================================
+ Hits            7867     7872       +5     
+ Misses          5683     5680       -3     
+ Partials         731      729       -2
Impacted Files Coverage Δ Complexity Δ
...server/store/file/FileTransactionStoreManager.java 60.85% <0%> (+1.64%) 30% <0%> (+1%) ⬆️

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly
Copy link
Member

simplify the pr title, for example optimize:xxx or refactor: xxx

@slievrly slievrly changed the title SagaTransactionalTemplate.java provide reloadTransaction method #1826 optimize:SagaTransactionalTemplate provide reloadTransaction method Oct 31, 2019
@slievrly slievrly changed the title optimize:SagaTransactionalTemplate provide reloadTransaction method optimize: SagaTransactionalTemplate provide reloadTransaction method Oct 31, 2019
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 54554b0 into apache:develop Nov 1, 2019
@slievrly slievrly added this to the 1.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants