-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: saga ExpressionEvaluator not support null value #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when paramType isAssignableFrom value.getClass()
…when paramType isAssignableFrom value.getClass()
Codecov Report
@@ Coverage Diff @@
## develop #1837 +/- ##
============================================
+ Coverage 54.95% 55.06% +0.1%
Complexity 2352 2352
============================================
Files 421 421
Lines 14266 14266
Branches 1682 1711 +29
============================================
+ Hits 7840 7855 +15
Misses 5681 5681
+ Partials 745 730 -15
|
slievrly
changed the title
Fix Saga ExpressionEvaluator not support null value #1829
bugfix: saga ExpressionEvaluator not support null value(#1837)
Oct 31, 2019
slievrly
changed the title
bugfix: saga ExpressionEvaluator not support null value(#1837)
bugfix: saga ExpressionEvaluator not support null value
Oct 31, 2019
slievrly
approved these changes
Oct 31, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zhangthen
approved these changes
Nov 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Fix Saga ExpressionEvaluator not support null value
Ⅱ. Does this pull request fix one issue?
#1829