Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: saga ExpressionEvaluator not support null value #1837

Merged
merged 56 commits into from
Nov 1, 2019

Conversation

long187
Copy link
Contributor

@long187 long187 commented Oct 29, 2019

Ⅰ. Describe what this PR did

Fix Saga ExpressionEvaluator not support null value

Ⅱ. Does this pull request fix one issue?

#1829

lorne.cl and others added 30 commits September 3, 2019 16:17
@codecov-io
Copy link

codecov-io commented Oct 29, 2019

Codecov Report

Merging #1837 into develop will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop    #1837     +/-   ##
============================================
+ Coverage      54.95%   55.06%   +0.1%     
  Complexity      2352     2352             
============================================
  Files            421      421             
  Lines          14266    14266             
  Branches        1682     1711     +29     
============================================
+ Hits            7840     7855     +15     
  Misses          5681     5681             
+ Partials         745      730     -15
Impacted Files Coverage Δ Complexity Δ
...rotobuf/convertor/RegisterTMResponseConvertor.java 84.84% <0%> (+3.03%) 3% <0%> (ø) ⬇️
...rotobuf/convertor/RegisterRMResponseConvertor.java 84.84% <0%> (+3.03%) 3% <0%> (ø) ⬇️
...otobuf/convertor/GlobalBeginResponseConvertor.java 96.96% <0%> (+3.03%) 3% <0%> (ø) ⬇️
...obuf/convertor/BranchRollbackRequestConvertor.java 96.42% <0%> (+3.57%) 3% <0%> (ø) ⬇️
...otobuf/convertor/BranchCommitRequestConvertor.java 100% <0%> (+3.57%) 3% <0%> (ø) ⬇️
...otobuf/convertor/BranchReportRequestConvertor.java 96.29% <0%> (+3.7%) 3% <0%> (ø) ⬇️
...protobuf/convertor/RegisterRMRequestConvertor.java 95.83% <0%> (+4.16%) 3% <0%> (ø) ⬇️
...protobuf/convertor/RegisterTMRequestConvertor.java 100% <0%> (+4.54%) 3% <0%> (ø) ⬇️
...otobuf/convertor/GlobalStatusRequestConvertor.java 100% <0%> (+5.26%) 3% <0%> (ø) ⬇️
...obuf/convertor/GlobalRollbackRequestConvertor.java 100% <0%> (+5.26%) 3% <0%> (ø) ⬇️
... and 3 more

@slievrly slievrly changed the title Fix Saga ExpressionEvaluator not support null value #1829 bugfix: saga ExpressionEvaluator not support null value(#1837) Oct 31, 2019
@slievrly slievrly changed the title bugfix: saga ExpressionEvaluator not support null value(#1837) bugfix: saga ExpressionEvaluator not support null value Oct 31, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhangthen zhangthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zhangthen zhangthen merged commit 5473a62 into apache:develop Nov 1, 2019
@slievrly slievrly added this to the 1.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants