Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: simplify and groom configuration items #1838

Merged
merged 11 commits into from
Nov 4, 2019
Merged

optimize: simplify and groom configuration items #1838

merged 11 commits into from
Nov 4, 2019

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

optimize: simplify and groom configuration items

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Oct 29, 2019

Codecov Report

Merging #1838 into develop will increase coverage by <.01%.
The diff coverage is 11.53%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #1838      +/-   ##
============================================
+ Coverage      55.39%   55.4%   +<.01%     
+ Complexity      2378    2376       -2     
============================================
  Files            422     422              
  Lines          14314   14319       +5     
  Branches        1716    1716              
============================================
+ Hits            7929    7933       +4     
+ Misses          5652    5645       -7     
- Partials         733     741       +8
Impacted Files Coverage Δ Complexity Δ
...ava/io/seata/core/constants/ConfigurationKeys.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ata/core/store/db/AbstractDataSourceGenerator.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 48.01% <14.63%> (-1.59%) 27 <2> (-1)
...server/store/file/FileTransactionStoreManager.java 59.21% <0%> (-0.99%) 29% <0%> (ø)
...in/java/io/seata/server/session/GlobalSession.java 84.54% <0%> (-0.49%) 67% <0%> (-1%)
.../java/io/seata/core/rpc/netty/NettyBaseConfig.java 36.11% <0%> (+13.88%) 2% <0%> (ø) ⬇️

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
@xingfudeshi xingfudeshi self-requested a review October 30, 2019 01:37
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Signed-off-by: slievrly <slievrly@163.com>
@zjinlei zjinlei added this to the 1.0 milestone Oct 30, 2019
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit aa308e3 into apache:develop Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants