-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: filter repeated lock #1839
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1839 +/- ##
=============================================
+ Coverage 54.95% 55.06% +0.11%
- Complexity 2352 2354 +2
=============================================
Files 421 422 +1
Lines 14266 14271 +5
Branches 1682 1712 +30
=============================================
+ Hits 7840 7859 +19
- Misses 5681 5683 +2
+ Partials 745 729 -16
|
(cherry picked from commit 0f5c1db)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend putting the duplicate lockkey in rm.
@zjinlei How to move the distinct logic to DataBaseLocker#acquireLock? Avoid where in the sql statement is too long |
...buf/src/main/resources/protobuf/io/seata/protocol/transcation/transactionExceptionCode.proto
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #1833
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
1.use @Transcation
2.batch write such as insert id (123),(124),(125)
3.update 123
Ⅴ. Special notes for reviews