Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: when branchCommit failed,it will trigger retry of multi-tc and throw npe #1845

Merged
merged 2 commits into from
Oct 31, 2019
Merged

bugfix: when branchCommit failed,it will trigger retry of multi-tc and throw npe #1845

merged 2 commits into from
Oct 31, 2019

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

bugfix: when branchCommit failed,it will trigger retry of multi-tc and throw npe

Ⅱ. Does this pull request fix one issue?

fix #1841

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

…d throw npe

Signed-off-by: slievrly <slievrly@163.com>
@zjinlei zjinlei added this to the 1.0 milestone Oct 30, 2019
@codecov-io
Copy link

codecov-io commented Oct 30, 2019

Codecov Report

Merging #1845 into develop will increase coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1845      +/-   ##
=============================================
+ Coverage      55.01%   55.04%   +0.02%     
  Complexity      2353     2353              
=============================================
  Files            422      422              
  Lines          14275    14279       +4     
  Branches        1713     1712       -1     
=============================================
+ Hits            7854     7860       +6     
- Misses          5687     5688       +1     
+ Partials         734      731       -3
Impacted Files Coverage Δ Complexity Δ
.../java/io/seata/server/coordinator/DefaultCore.java 42.68% <0%> (ø) 26 <0> (ø) ⬇️
...va/io/seata/core/store/db/LogStoreDataBaseDAO.java 59.47% <100%> (+0.41%) 21 <0> (ø) ⬇️
...a/io/seata/core/store/db/LockStoreDataBaseDAO.java 53.71% <100%> (+0.84%) 20 <0> (ø) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 49.19% <28.57%> (-0.4%) 27 <0> (ø)
...server/store/file/FileTransactionStoreManager.java 59.21% <0%> (+0.65%) 29% <0%> (ø) ⬇️

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lightClouds917 lightClouds917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.8.1 TC集群部署时,TC节点间重复二阶段提交同一个事务导致的报错
5 participants