Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: multi-thread concurrent add listener problem #1846

Merged
merged 3 commits into from
Oct 31, 2019
Merged

bugfix: multi-thread concurrent add listener problem #1846

merged 3 commits into from
Oct 31, 2019

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

bugfix: multi-thread concurrent add listener problem

Ⅱ. Does this pull request fix one issue?

fix #1830

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Oct 30, 2019

Codecov Report

Merging #1846 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1846      +/-   ##
=============================================
- Coverage      55.06%   55.05%   -0.01%     
- Complexity      2353     2355       +2     
=============================================
  Files            422      422              
  Lines          14273    14273              
  Branches        1712     1712              
=============================================
- Hits            7859     7858       -1     
- Misses          5684     5686       +2     
+ Partials         730      729       -1
Impacted Files Coverage Δ Complexity Δ
...server/store/file/FileTransactionStoreManager.java 59.21% <0%> (-0.99%) 29% <0%> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 50% <0%> (+0.4%) 28% <0%> (+1%) ⬆️
...in/java/io/seata/server/session/GlobalSession.java 85.02% <0%> (+0.48%) 68% <0%> (+1%) ⬆️

@zjinlei zjinlei added this to the 1.0 milestone Oct 30, 2019
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.The other registry implementations may have similar problem.

@slievrly
Copy link
Member Author

LGTM.The other registry implementations may have similar problem.

multiple listeners will not affect us, but there may be a registry that may throw a ConcurrentModificationException.

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 21078b7 into apache:develop Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There will be two identical EventListener add to EventDispatcher when using Nacos naming service.
4 participants