-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: protostuff undo log get default content #1856
Conversation
Pull the latest code
…gWithGlobalFinished method
…ff undo log parser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add UT for decode(getDefaultContent())
Codecov Report
@@ Coverage Diff @@
## develop #1856 +/- ##
=============================================
+ Coverage 55.05% 55.12% +0.06%
- Complexity 2355 2359 +4
=============================================
Files 422 422
Lines 14279 14281 +2
Branches 1712 1712
=============================================
+ Hits 7861 7872 +11
+ Misses 5688 5681 -7
+ Partials 730 728 -2
|
7349cd6
to
622d0ac
Compare
@iapplejohn please relation user.email to github email, user.name to github account. |
@jsbxyyx , Shall I delete the previous commits and re-submit with the github username and email? |
@iapplejohn |
…n/seata into protostuff_undo_0_byte
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
retry ci |
Ⅰ. Describe what this PR did
Return a byte array with one element so that the program would not throw javax.sql.rowset.serial.SerialException.
Ⅱ. Does this pull request fix one issue?
fixes #1848
Ⅲ. Why don't you add test cases (unit test/integration test)?
MySQLUndoLogManagerTest.testInsertUndoLog could not showcase the issue, for it uses mock driver.
Ⅳ. Describe how to verify it
Utilize MySQL server
Ⅴ. Special notes for reviews