Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: protostuff undo log get default content #1856

Merged
merged 11 commits into from
Nov 1, 2019

Conversation

iapplejohn
Copy link
Contributor

Ⅰ. Describe what this PR did

Return a byte array with one element so that the program would not throw javax.sql.rowset.serial.SerialException.

Ⅱ. Does this pull request fix one issue?

fixes #1848

Ⅲ. Why don't you add test cases (unit test/integration test)?

MySQLUndoLogManagerTest.testInsertUndoLog could not showcase the issue, for it uses mock driver.

Ⅳ. Describe how to verify it

Utilize MySQL server

Ⅴ. Special notes for reviews

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add UT for decode(getDefaultContent())

@codecov-io
Copy link

codecov-io commented Oct 31, 2019

Codecov Report

Merging #1856 into develop will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1856      +/-   ##
=============================================
+ Coverage      55.05%   55.12%   +0.06%     
- Complexity      2355     2359       +4     
=============================================
  Files            422      422              
  Lines          14279    14281       +2     
  Branches        1712     1712              
=============================================
+ Hits            7861     7872      +11     
+ Misses          5688     5681       -7     
+ Partials         730      728       -2
Impacted Files Coverage Δ Complexity Δ
...m/datasource/undo/parser/JacksonUndoLogParser.java 71.25% <100%> (+0.73%) 7 <2> (+1) ⬆️
...atasource/undo/parser/ProtostuffUndoLogParser.java 44.89% <100%> (+2.04%) 5 <1> (+1) ⬆️
...server/store/file/FileTransactionStoreManager.java 60.19% <0%> (+1.31%) 29% <0%> (ø) ⬇️
.../datasource/undo/parser/FastjsonUndoLogParser.java 85.71% <0%> (+14.28%) 4% <0%> (+1%) ⬆️
...a/rm/datasource/undo/parser/KryoUndoLogParser.java 90.9% <0%> (+27.27%) 4% <0%> (+1%) ⬆️

@jsbxyyx
Copy link
Member

jsbxyyx commented Oct 31, 2019

@iapplejohn please relation user.email to github email, user.name to github account.

@iapplejohn
Copy link
Contributor Author

@jsbxyyx , Shall I delete the previous commits and re-submit with the github username and email?

@jsbxyyx
Copy link
Member

jsbxyyx commented Oct 31, 2019

@iapplejohn git commit --amend update last commit.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zjinlei
Copy link
Contributor

zjinlei commented Nov 1, 2019

retry ci

@zjinlei zjinlei closed this Nov 1, 2019
@zjinlei zjinlei reopened this Nov 1, 2019
@zjinlei zjinlei closed this Nov 1, 2019
@zjinlei zjinlei reopened this Nov 1, 2019
@jsbxyyx jsbxyyx merged commit a8b5110 into apache:develop Nov 1, 2019
@iapplejohn iapplejohn deleted the protostuff_undo_0_byte branch November 1, 2019 03:08
@slievrly slievrly added this to the 1.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

insertUndoLogWithGlobalFinished failed when using protostuff
7 participants