Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix:fix Global transaction does not work #1858

Merged
merged 1 commit into from
Oct 31, 2019
Merged

bugfix:fix Global transaction does not work #1858

merged 1 commit into from
Oct 31, 2019

Conversation

xingfudeshi
Copy link
Member

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #1857

Ⅲ. Why don't you add test cases (unit test/integration test)?

I've done integration testing.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@xingfudeshi xingfudeshi changed the title fix Global transaction does not work bugfix:fix Global transaction does not work Oct 31, 2019
@codecov-io
Copy link

codecov-io commented Oct 31, 2019

Codecov Report

Merging #1858 into develop will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1858      +/-   ##
=============================================
- Coverage      55.07%   55.04%   -0.04%     
+ Complexity      2354     2353       -1     
=============================================
  Files            422      422              
  Lines          14273    14273              
  Branches        1712     1712              
=============================================
- Hits            7861     7856       -5     
- Misses          5683     5686       +3     
- Partials         729      731       +2
Impacted Files Coverage Δ Complexity Δ
...ta/spring/annotation/GlobalTransactionScanner.java 50% <0%> (ø) 17 <0> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 59.21% <0%> (-1.65%) 29% <0%> (-1%)

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly
Copy link
Member

image
check result is ok.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global Transaction does not work
4 participants