Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize: optimize no primary key output log #1861

Merged
merged 3 commits into from
Oct 31, 2019
Merged

optimize: optimize no primary key output log #1861

merged 3 commits into from
Oct 31, 2019

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Oct 31, 2019 •
edited by zjinlei

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

optimize: optimize no primary key output log

Ⅱ. Does this pull request fix one issue?

fix #1860 #1854

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@slievrly
optimize: optimize no primary key output log
25bdf38 
Signed-off-by: slievrly <slievrly@163.com>
jsbxyyx
jsbxyyx approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsbxyyx jsbxyyx self-requested a review October 31, 2019 10:33
jsbxyyx
jsbxyyx reviewed Oct 31, 2019
View reviewed changes
Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split TableMetaTest#testContainsPK two case.

@zjinlei
Copy link
Contributor

zjinlei commented Oct 31, 2019

image

@slievrly
fix UT
ad95992 
Signed-off-by: slievrly <slievrly@163.com>
@slievrly
Copy link
Member Author

@zjinlei fixed.

@codecov-io
Copy link

codecov-io commented Oct 31, 2019 •
edited

Codecov Report

Merging #1861 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1861      +/-   ##
=============================================
+ Coverage      55.04%   55.05%   +0.01%     
  Complexity      2353     2353              
=============================================
  Files            422      422              
  Lines          14273    14275       +2     
  Branches        1712     1713       +1     
=============================================
+ Hits            7856     7859       +3     
+ Misses          5686     5685       -1     
  Partials         731      731
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/io/seata/common/util/LambdaUtils.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...a/io/seata/rm/datasource/sql/struct/TableMeta.java 96.82% <100%> (-3.18%) 30 <0> (ø)
...server/store/file/FileTransactionStoreManager.java 60.19% <0%> (+0.98%) 29% <0%> (ø) ⬇️

xingfudeshi
xingfudeshi approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit e6a7e7c into apache:develop Oct 31, 2019
@slievrly slievrly added this to the 1.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsbxyyx jsbxyyx jsbxyyx approved these changes

@xingfudeshi xingfudeshi xingfudeshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

throw IndexOutOfBoundsException with no primary key, requiring more friendly information
5 participants
@slievrly @zjinlei @codecov-io @xingfudeshi @jsbxyyx