Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix the other of column type cause rollback fail #1863

Merged
merged 5 commits into from
Nov 5, 2019

Conversation

l81893521
Copy link
Contributor

Ⅰ. Describe what this PR did

Oracle Driver dose not support the other type of column

Ⅱ. Does this pull request fix one issue?

#1831

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Oct 31, 2019

Codecov Report

Merging #1863 into develop will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1863      +/-   ##
=============================================
- Coverage      55.45%   55.41%   -0.04%     
  Complexity      2379     2379              
=============================================
  Files            422      422              
  Lines          14319    14320       +1     
  Branches        1716     1717       +1     
=============================================
- Hits            7940     7936       -4     
- Misses          5642     5644       +2     
- Partials         737      740       +3
Impacted Files Coverage Δ Complexity Δ
...seata/rm/datasource/undo/AbstractUndoExecutor.java 74.33% <0%> (-0.67%) 21 <0> (ø)
...server/store/file/FileTransactionStoreManager.java 59.53% <0%> (-1.32%) 30% <0%> (ø)

@zjinlei zjinlei added this to the 1.0 milestone Nov 2, 2019
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit dac895b into apache:develop Nov 5, 2019
@l81893521 l81893521 deleted the fix_serialize_other_type branch November 20, 2019 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants