Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: server lack of error trace #1866

Merged
merged 10 commits into from
Nov 2, 2019

Conversation

l81893521
Copy link
Contributor

Ⅰ. Describe what this PR did

log the error when branch register fail.

Ⅱ. Does this pull request fix one issue?

#1865

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Nov 1, 2019

Codecov Report

Merging #1866 into develop will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1866      +/-   ##
=============================================
- Coverage      55.37%   55.35%   -0.02%     
+ Complexity      2378     2376       -2     
=============================================
  Files            422      422              
  Lines          14314    14314              
  Branches        1716     1716              
=============================================
- Hits            7926     7924       -2     
  Misses          5654     5654              
- Partials         734      736       +2
Impacted Files Coverage Δ Complexity Δ
.../java/io/seata/server/coordinator/DefaultCore.java 42.68% <0%> (ø) 26 <0> (ø) ⬇️
...java/io/seata/server/AbstractTCInboundHandler.java 1.21% <0%> (ø) 1 <0> (ø) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 84.54% <0%> (-0.49%) 67% <0%> (-1%)
...o/seata/server/coordinator/DefaultCoordinator.java 49.19% <0%> (-0.41%) 27% <0%> (-1%)

zjinlei
zjinlei previously approved these changes Nov 1, 2019
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zjinlei zjinlei dismissed their stale review November 1, 2019 09:52

Recommended to throw,and solve the link that is eaten in the middle

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei changed the title optimize: lack of error trace optimize: server lack of error trace Nov 2, 2019
@zjinlei zjinlei merged commit 2347636 into apache:develop Nov 2, 2019
@l81893521 l81893521 deleted the lack_of_error_trace branch November 20, 2019 07:55
@slievrly slievrly added this to the 1.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants