-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: server lack of error trace #1866
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1866 +/- ##
=============================================
- Coverage 55.37% 55.35% -0.02%
+ Complexity 2378 2376 -2
=============================================
Files 422 422
Lines 14314 14314
Branches 1716 1716
=============================================
- Hits 7926 7924 -2
Misses 5654 5654
- Partials 734 736 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
server/src/main/java/io/seata/server/coordinator/DefaultCore.java
Outdated
Show resolved
Hide resolved
Recommended to throw,and solve the link that is eaten in the middle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
log the error when branch register fail.
Ⅱ. Does this pull request fix one issue?
#1865
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews