Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize:optimization of seata-spring-boot-starter #1867

Merged
merged 1 commit into from
Nov 2, 2019
Merged

optimize:optimization of seata-spring-boot-starter #1867

merged 1 commit into from
Nov 2, 2019

Conversation

xingfudeshi
Copy link
Member

Ⅰ. Describe what this PR did

1.remove @ConditionalOnClass(DataSourceProxy.class)
2.add attribute havingValue = "true" in @ConditionalOnProperty

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

I've done integration testing.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Nov 1, 2019

Codecov Report

Merging #1867 into develop will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1867      +/-   ##
=============================================
- Coverage      55.34%   55.24%   -0.11%     
  Complexity      2376     2376              
=============================================
  Files            422      422              
  Lines          14314    14286      -28     
  Branches        1716     1676      -40     
=============================================
- Hits            7922     7892      -30     
+ Misses          5655     5646       -9     
- Partials         737      748      +11
Impacted Files Coverage Δ Complexity Δ
...obuf/convertor/BranchRegisterRequestConvertor.java 88% <0%> (-8%) 3% <0%> (ø)
...buf/convertor/GlobalLockQueryRequestConvertor.java 92.59% <0%> (-7.41%) 3% <0%> (ø)
...otobuf/convertor/GlobalStatusRequestConvertor.java 94.73% <0%> (-5.27%) 3% <0%> (ø)
...obuf/convertor/GlobalRollbackRequestConvertor.java 94.73% <0%> (-5.27%) 3% <0%> (ø)
...otobuf/convertor/GlobalCommitRequestConvertor.java 94.73% <0%> (-5.27%) 3% <0%> (ø)
...protobuf/convertor/RegisterTMRequestConvertor.java 95.45% <0%> (-4.55%) 3% <0%> (ø)
...protobuf/convertor/RegisterRMRequestConvertor.java 91.66% <0%> (-4.17%) 3% <0%> (ø)
...otobuf/convertor/BranchReportRequestConvertor.java 92.59% <0%> (-3.71%) 3% <0%> (ø)
...rotobuf/convertor/RegisterTMResponseConvertor.java 81.25% <0%> (-3.6%) 3% <0%> (ø)
...rotobuf/convertor/RegisterRMResponseConvertor.java 81.25% <0%> (-3.6%) 3% <0%> (ø)
... and 18 more

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit f4af62c into apache:develop Nov 2, 2019
@slievrly slievrly added this to the 1.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants