Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: adapt springcloud-alibaba-seata autoconfig #1871

Merged
merged 5 commits into from
Nov 11, 2019
Merged

feature: adapt springcloud-alibaba-seata autoconfig #1871

merged 5 commits into from
Nov 11, 2019

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Nov 4, 2019

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

feature: adapt springcloud-alibaba-seata autoconfig

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

image
image

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Nov 4, 2019

Codecov Report

Merging #1871 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1871      +/-   ##
=============================================
+ Coverage      55.31%   55.33%   +0.01%     
  Complexity      2380     2380              
=============================================
  Files            423      423              
  Lines          14270    14270              
  Branches        1693     1693              
=============================================
+ Hits            7894     7896       +2     
+ Misses          5663     5662       -1     
+ Partials         713      712       -1
Impacted Files Coverage Δ Complexity Δ
...very/registry/zk/ZookeeperRegisterServiceImpl.java 63.77% <0%> (-0.79%) 25% <0%> (ø)
...server/store/file/FileTransactionStoreManager.java 57.91% <0%> (+0.94%) 29% <0%> (ø) ⬇️

Copy link
Member

@fangjian0423 fangjian0423 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei added this to the 1.0 milestone Nov 4, 2019
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

slievrly and others added 2 commits November 11, 2019 17:09
Signed-off-by: slievrly <slievrly@163.com>
@jsbxyyx jsbxyyx merged commit f6bfa7a into apache:develop Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants