-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: when write the new file throw ClosedChannelException #1874
Conversation
Signed-off-by: slievrly <slievrly@163.com>
Codecov Report
@@ Coverage Diff @@
## develop #1874 +/- ##
=============================================
- Coverage 55.41% 55.36% -0.06%
Complexity 2376 2376
=============================================
Files 422 422
Lines 14320 14331 +11
Branches 1717 1717
=============================================
- Hits 7936 7934 -2
- Misses 5643 5655 +12
- Partials 741 742 +1
|
@fx1061076658 please verify this pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已验证通过
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Signed-off-by: slievrly <slievrly@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
and also can modify closeAndFlush
Signed-off-by: slievrly slievrly@163.com
Ⅰ. Describe what this PR did
bugfix: when write the new file throw ClosedChannelException
Ⅱ. Does this pull request fix one issue?
fix #1875
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews