Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: when write the new file throw ClosedChannelException #1874

Merged
merged 2 commits into from
Nov 6, 2019
Merged

bugfix: when write the new file throw ClosedChannelException #1874

merged 2 commits into from
Nov 6, 2019

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Nov 5, 2019

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

bugfix: when write the new file throw ClosedChannelException

Ⅱ. Does this pull request fix one issue?

fix #1875

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Nov 5, 2019

Codecov Report

Merging #1874 into develop will decrease coverage by 0.05%.
The diff coverage is 6.25%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1874      +/-   ##
=============================================
- Coverage      55.41%   55.36%   -0.06%     
  Complexity      2376     2376              
=============================================
  Files            422      422              
  Lines          14320    14331      +11     
  Branches        1717     1717              
=============================================
- Hits            7936     7934       -2     
- Misses          5643     5655      +12     
- Partials         741      742       +1
Impacted Files Coverage Δ Complexity Δ
...server/store/file/FileTransactionStoreManager.java 57.14% <0%> (-3.06%) 29 <0> (ø)
...main/java/io/seata/server/store/FlushDiskMode.java 77.77% <50%> (ø) 3 <2> (ø) ⬇️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 64.56% <0%> (+0.78%) 25% <0%> (ø) ⬇️

@slievrly
Copy link
Member Author

slievrly commented Nov 5, 2019

@fx1061076658 please verify this pr.

Copy link

@fx1061076658 fx1061076658 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link

@fx1061076658 fx1061076658 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link

@fx1061076658 fx1061076658 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已验证通过

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Signed-off-by: slievrly <slievrly@163.com>
Copy link
Contributor

@CoffeeLatte007 CoffeeLatte007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
and also can modify closeAndFlush

@CoffeeLatte007 CoffeeLatte007 merged commit 4f28687 into apache:develop Nov 6, 2019
@slievrly slievrly added this to the 1.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants