Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: jdbc parameter set null #1879

Merged
merged 2 commits into from
Nov 8, 2019
Merged

bugfix: jdbc parameter set null #1879

merged 2 commits into from
Nov 8, 2019

Conversation

jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented Nov 6, 2019

Ⅰ. Describe what this PR did

jdbc parameter set null, cause error.

Ⅱ. Does this pull request fix one issue?

fixes #1852

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@jsbxyyx jsbxyyx requested review from l81893521 and slievrly and removed request for l81893521 November 6, 2019 14:09
@codecov-io
Copy link

codecov-io commented Nov 6, 2019

Codecov Report

Merging #1879 into develop will decrease coverage by 0.14%.
The diff coverage is 50%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1879      +/-   ##
=============================================
- Coverage      55.36%   55.22%   -0.15%     
+ Complexity      2379     2376       -3     
=============================================
  Files            422      422              
  Lines          14331    14305      -26     
  Branches        1717     1679      -38     
=============================================
- Hits            7935     7900      -35     
+ Misses          5656     5649       -7     
- Partials         740      756      +16
Impacted Files Coverage Δ Complexity Δ
...a/rm/datasource/sql/druid/BaseMySQLRecognizer.java 94.44% <50%> (-2.7%) 12 <0> (ø)
...asource/sql/druid/oracle/BaseOracleRecognizer.java 94.44% <50%> (-2.7%) 12 <0> (ø)
...obuf/convertor/BranchRegisterRequestConvertor.java 88% <0%> (-8%) 3% <0%> (ø)
...buf/convertor/GlobalLockQueryRequestConvertor.java 92.59% <0%> (-7.41%) 3% <0%> (ø)
...otobuf/convertor/GlobalStatusRequestConvertor.java 94.73% <0%> (-5.27%) 3% <0%> (ø)
...obuf/convertor/GlobalRollbackRequestConvertor.java 94.73% <0%> (-5.27%) 3% <0%> (ø)
...otobuf/convertor/GlobalCommitRequestConvertor.java 94.73% <0%> (-5.27%) 3% <0%> (ø)
...protobuf/convertor/RegisterTMRequestConvertor.java 95.45% <0%> (-4.55%) 3% <0%> (ø)
...protobuf/convertor/RegisterRMRequestConvertor.java 91.66% <0%> (-4.17%) 3% <0%> (ø)
...otobuf/convertor/BranchReportRequestConvertor.java 92.59% <0%> (-3.71%) 3% <0%> (ø)
... and 20 more

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 6e7d88c into apache:develop Nov 8, 2019
@slievrly slievrly added this to the 1.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

throw Invalid argument value: java.io.NotSerializableException when give null to parameter in Mapper.xml
4 participants