-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugifx: fix saga dose not delete branches when transaction ended #1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1893 +/- ##
=============================================
- Coverage 55.19% 55.12% -0.07%
+ Complexity 2404 2402 -2
=============================================
Files 429 429
Lines 14247 14261 +14
Branches 1668 1673 +5
=============================================
- Hits 7863 7861 -2
- Misses 5678 5693 +15
- Partials 706 707 +1
|
slievrly
approved these changes
Nov 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
slievrly
changed the title
Bugifx: Fix saga dose not delete branches when transaction ended. #1887
bugifx: fix saga dose not delete branches when transaction ended
Nov 15, 2019
xingfudeshi
approved these changes
Nov 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Fix saga dose not delete branches when transaction ended.
Optimize: RetryState and CompensateState dose not registry branch to Server now, only the original state instance is registered on the server, and its status should be reported.
Ⅱ. Does this pull request fix one issue?
#1887