Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugifx: fix saga dose not delete branches when transaction ended #1893

Merged
merged 7 commits into from
Nov 25, 2019

Conversation

long187
Copy link
Contributor

@long187 long187 commented Nov 13, 2019

Ⅰ. Describe what this PR did

Fix saga dose not delete branches when transaction ended.
Optimize: RetryState and CompensateState dose not registry branch to Server now, only the original state instance is registered on the server, and its status should be reported.

Ⅱ. Does this pull request fix one issue?

#1887

@codecov-io
Copy link

codecov-io commented Nov 13, 2019

Codecov Report

Merging #1893 into develop will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1893      +/-   ##
=============================================
- Coverage      55.19%   55.12%   -0.07%     
+ Complexity      2404     2402       -2     
=============================================
  Files            429      429              
  Lines          14247    14261      +14     
  Branches        1668     1673       +5     
=============================================
- Hits            7863     7861       -2     
- Misses          5678     5693      +15     
- Partials         706      707       +1
Impacted Files Coverage Δ Complexity Δ
.../java/io/seata/server/coordinator/DefaultCore.java 39.58% <0%> (-2.03%) 26 <0> (ø)
...server/store/file/FileTransactionStoreManager.java 56.5% <0%> (-0.64%) 29% <0%> (-1%)

@zjinlei zjinlei added this to the 1.0 milestone Nov 14, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title Bugifx: Fix saga dose not delete branches when transaction ended. #1887 bugifx: fix saga dose not delete branches when transaction ended Nov 15, 2019
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@slievrly slievrly merged commit 258760b into apache:develop Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants