Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean: remove clientTest it's not use #1897

Merged
merged 3 commits into from
Nov 15, 2019
Merged

clean: remove clientTest it's not use #1897

merged 3 commits into from
Nov 15, 2019

Conversation

ruqinhu
Copy link
Contributor

@ruqinhu ruqinhu commented Nov 13, 2019

Ⅰ. Describe what this PR did

delete not use bean

Ⅱ. Does this pull request fix one issue?

it is not be defined

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Nov 13, 2019

Codecov Report

Merging #1897 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1897      +/-   ##
=============================================
- Coverage      55.43%   55.41%   -0.03%     
  Complexity      2406     2406              
=============================================
  Files            428      428              
  Lines          14346    14346              
  Branches        1699     1699              
=============================================
- Hits            7953     7950       -3     
- Misses          5677     5679       +2     
- Partials         716      717       +1
Impacted Files Coverage Δ Complexity Δ
...server/store/file/FileTransactionStoreManager.java 56.96% <0%> (-0.95%) 29% <0%> (ø)

@slievrly slievrly changed the title refactor: clientTest is not use,delete clean: remove clientTest it's not use Nov 15, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi merged commit 69faa89 into apache:develop Nov 15, 2019
@slievrly slievrly added this to the 1.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants