Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support dynamic config #1898

Merged
merged 19 commits into from
Dec 11, 2019
Merged

feature: support dynamic config #1898

merged 19 commits into from
Dec 11, 2019

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

feature: support dynamic config

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Nov 14, 2019

Codecov Report

Merging #1898 into develop will decrease coverage by 0.23%.
The diff coverage is 43.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1898      +/-   ##
=============================================
- Coverage      55.31%   55.07%   -0.24%     
- Complexity      2439     2472      +33     
=============================================
  Files            434      444      +10     
  Lines          14470    14758     +288     
  Branches        1707     1743      +36     
=============================================
+ Hits            8004     8128     +124     
- Misses          5744     5883     +139     
- Partials         722      747      +25
Impacted Files Coverage Δ Complexity Δ
...e/src/main/java/io/seata/config/Configuration.java 100% <ø> (ø) 1 <0> (?)
.../java/io/seata/config/ConfigurationChangeType.java 0% <0%> (ø) 0 <0> (?)
...in/java/io/seata/config/AbstractConfiguration.java 25.92% <100%> (ø) 6 <1> (?)
...ava/io/seata/common/thread/NamedThreadFactory.java 90% <100%> (-0.48%) 6 <2> (ø)
...java/io/seata/config/ConfigurationChangeEvent.java 38.46% <38.46%> (ø) 6 <6> (?)
...a/io/seata/config/ConfigurationChangeListener.java 41.66% <41.66%> (ø) 4 <4> (?)
...c/main/java/io/seata/config/FileConfiguration.java 41.66% <47.72%> (ø) 6 <3> (?)
...ain/java/io/seata/config/ConfigurationFactory.java 52% <50%> (ø) 3 <0> (?)
...ource/sql/struct/cache/AbstractTableMetaCache.java 85.29% <0%> (-2.95%) 11% <0%> (-1%)
...in/java/io/seata/server/session/GlobalSession.java 84.54% <0%> (-0.49%) 67% <0%> (-1%)
... and 12 more

@zjinlei zjinlei added this to the 1.0 milestone Nov 14, 2019
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
slievrly and others added 2 commits December 10, 2019 11:31
Signed-off-by: slievrly <slievrly@163.com>
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test File and Nacos well.
LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File test passed. LGTM

@zjinlei zjinlei merged commit 41ad489 into apache:develop Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants