-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: support dynamic config #1898
Conversation
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Codecov Report
@@ Coverage Diff @@
## develop #1898 +/- ##
=============================================
- Coverage 55.31% 55.07% -0.24%
- Complexity 2439 2472 +33
=============================================
Files 434 444 +10
Lines 14470 14758 +288
Branches 1707 1743 +36
=============================================
+ Hits 8004 8128 +124
- Misses 5744 5883 +139
- Partials 722 747 +25
|
config/seata-config-etcd3/src/main/java/io/seata/config/etcd3/EtcdConfiguration.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
config/seata-config-core/src/main/java/io/seata/config/FileConfiguration.java
Show resolved
Hide resolved
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
config/seata-config-core/src/main/java/io/seata/config/FileConfiguration.java
Show resolved
Hide resolved
Signed-off-by: slievrly <slievrly@163.com>
config/seata-config-core/src/main/java/io/seata/config/FileConfiguration.java
Outdated
Show resolved
Hide resolved
Signed-off-by: slievrly <slievrly@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test File and Nacos well.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File test passed. LGTM
Signed-off-by: slievrly slievrly@163.com
Ⅰ. Describe what this PR did
feature: support dynamic config
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews