Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: batch query branchSession by xid list #1903

Merged
merged 26 commits into from
Nov 19, 2019

Conversation

zjinlei
Copy link
Contributor

@zjinlei zjinlei commented Nov 14, 2019

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Nov 14, 2019

Codecov Report

Merging #1903 into develop will decrease coverage by 0.06%.
The diff coverage is 24.24%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1903      +/-   ##
=============================================
- Coverage      55.39%   55.32%   -0.07%     
- Complexity      2404     2405       +1     
=============================================
  Files            428      428              
  Lines          14349    14361      +12     
  Branches        1697     1695       -2     
=============================================
- Hits            7948     7945       -3     
- Misses          5684     5698      +14     
- Partials         717      718       +1
Impacted Files Coverage Δ Complexity Δ
...main/java/io/seata/core/store/db/LogStoreSqls.java 18.86% <0%> (-0.74%) 10 <0> (ø)
...rver/store/db/DatabaseTransactionStoreManager.java 65.9% <100%> (ø) 22 <1> (ø) ⬇️
...va/io/seata/core/store/db/LogStoreDataBaseDAO.java 55.59% <4.16%> (-1.9%) 21 <0> (ø)
...very/registry/zk/ZookeeperRegisterServiceImpl.java 63.77% <0%> (-0.79%) 25% <0%> (ø)
...server/store/file/FileTransactionStoreManager.java 57.27% <0%> (-0.64%) 30% <0%> (+1%)

@zjinlei zjinlei added this to the 1.0 milestone Nov 14, 2019
Copy link
Contributor

@andyqian andyqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@helloworlde helloworlde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 34a5c0f into apache:develop Nov 19, 2019
@zjinlei zjinlei deleted the optimize/batchQueryBranchSession branch November 19, 2019 04:24
@zjinlei zjinlei added the theme: performance An issue or pr that we don't feel is valid label Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: performance An issue or pr that we don't feel is valid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants