Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: solve the lock_key length problem #1905

Merged
merged 20 commits into from
Dec 2, 2019

Conversation

zjinlei
Copy link
Contributor

@zjinlei zjinlei commented Nov 15, 2019

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #1904

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

…e/lockKey

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@codecov-io
Copy link

codecov-io commented Nov 15, 2019

Codecov Report

Merging #1905 into develop will decrease coverage by 0.23%.
The diff coverage is 19.41%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1905      +/-   ##
=============================================
- Coverage       55.5%   55.26%   -0.24%     
+ Complexity      2433     2431       -2     
=============================================
  Files            430      431       +1     
  Lines          14397    14442      +45     
  Branches        1707     1708       +1     
=============================================
- Hits            7991     7982       -9     
- Misses          5680     5734      +54     
  Partials         726      726
Impacted Files Coverage Δ Complexity Δ
...rver/store/db/DatabaseTransactionStoreManager.java 65.38% <ø> (-0.53%) 22 <0> (ø)
...o/seata/core/constants/ServerTableColumnsName.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...main/java/io/seata/core/store/db/LogStoreSqls.java 18.86% <ø> (ø) 10 <0> (ø) ⬇️
.../java/io/seata/core/store/BranchTransactionDO.java 91.66% <ø> (-0.65%) 21 <0> (-2)
...ain/java/io/seata/core/store/db/LockStoreSqls.java 21.42% <0%> (-3.58%) 3 <0> (ø)
...n/java/io/seata/server/lock/db/DataBaseLocker.java 16.27% <0%> (-7.86%) 5 <0> (ø)
...a/io/seata/server/lock/db/DataBaseLockManager.java 0% <0%> (ø) 0 <0> (?)
...a/io/seata/core/store/db/LockStoreDataBaseDAO.java 43.07% <0%> (-7.53%) 18 <0> (ø)
...c/main/java/io/seata/core/lock/AbstractLocker.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...va/io/seata/core/store/db/LogStoreDataBaseDAO.java 55.44% <100%> (-0.3%) 21 <0> (ø)
... and 4 more

@zjinlei zjinlei changed the title optimize: solve the lock_key length problem feature: solve the lock_key length problem Nov 15, 2019
@zjinlei zjinlei added this to the 1.0 milestone Nov 16, 2019
@slievrly
Copy link
Member

slievrly commented Dec 2, 2019

image
function check pass.

@slievrly
Copy link
Member

slievrly commented Dec 2, 2019

File mode releases the lock according to pk, db mode releases the lock according to branchId, and branch_table will no longer store lock_key information. AbstractLockManager will be promoted to a common logical base class, and DefaultLockManager will be used as a non-db mode processing class.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 34b8060 into apache:develop Dec 2, 2019
@zjinlei zjinlei deleted the optimize/lockKey branch December 22, 2019 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: solve the lock_key length problem
5 participants