bugfix: add exception system exit code when rpcServer init. #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cServer init exception.
Codecov Report
@@ Coverage Diff @@
## develop #1906 +/- ##
=============================================
- Coverage 55.43% 55.41% -0.03%
- Complexity 2406 2408 +2
=============================================
Files 428 428
Lines 14346 14351 +5
Branches 1699 1699
=============================================
- Hits 7953 7952 -1
- Misses 5677 5684 +7
+ Partials 716 715 -1
|
slievrly
changed the title
l81893521
reviewed
Nov 18, 2019
| try { | ||
| rpcServer.init(); | ||
| } catch (Throwable e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
Why do not use LOGGER.error instead of e.printStackTrace();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cServer init exception.
Ⅰ. Describe what this PR did
We need to tell the system something about code(eg:-1) when tc server abnormal exit system
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews