-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix xidInterceptorType is null #1909
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## develop #1909 +/- ##
=============================================
+ Coverage 55.41% 55.42% +<.01%
- Complexity 2406 2407 +1
=============================================
Files 428 428
Lines 14351 14353 +2
Branches 1699 1700 +1
=============================================
+ Hits 7953 7955 +2
- Misses 5682 5683 +1
+ Partials 716 715 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public static void bindInterceptorType(String xidType) {
if(StringUtils.isNotBlank(xidType)){
String[] xidTypes = xidType.split("_");
if(xidTypes.length == 2){
bindInterceptorType(xidTypes[0], BranchType.valueOf(xidTypes[1]));
}
}
}
9a0480a
to
bc97c75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #1908
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews