Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix xidInterceptorType is null #1909

Merged
merged 2 commits into from
Nov 18, 2019

Conversation

cmonkey
Copy link
Contributor

@cmonkey cmonkey commented Nov 18, 2019

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #1908

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei changed the title bugfix: fix xidInterceptorType is null (#1908) bugfix: fix xidInterceptorType is null Nov 18, 2019
@codecov-io
Copy link

codecov-io commented Nov 18, 2019

Codecov Report

Merging #1909 into develop will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1909      +/-   ##
=============================================
+ Coverage      55.41%   55.42%   +<.01%     
- Complexity      2406     2407       +1     
=============================================
  Files            428      428              
  Lines          14351    14353       +2     
  Branches        1699     1700       +1     
=============================================
+ Hits            7953     7955       +2     
- Misses          5682     5683       +1     
+ Partials         716      715       -1
Impacted Files Coverage Δ Complexity Δ
...c/main/java/io/seata/core/context/RootContext.java 36.17% <0%> (-1.61%) 9 <0> (ø)
...server/store/file/FileTransactionStoreManager.java 58.54% <0%> (+0.63%) 30% <0%> (+1%) ⬆️

Copy link
Contributor

@zhongfuhua zhongfuhua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public static void bindInterceptorType(String xidType) {
        if(StringUtils.isNotBlank(xidType)){
            String[] xidTypes = xidType.split("_");
            if(xidTypes.length == 2){
                bindInterceptorType(xidTypes[0], BranchType.valueOf(xidTypes[1]));
            }
        }
    }

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 67f932c into apache:develop Nov 18, 2019
@cmonkey cmonkey deleted the feature/bugfix-1908 branch November 18, 2019 12:32
@slievrly slievrly added this to the 1.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AT模式下Dubbo集成报xidInterceptorType空指针异常
6 participants