Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize : all override methods must be annotated with "@override" #1910

Merged
merged 2 commits into from
Nov 19, 2019
Merged

optimize : all override methods must be annotated with "@override" #1910

merged 2 commits into from
Nov 19, 2019

Conversation

EZKAYOTWJPRKXWCUYEEB
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Nov 19, 2019 •
edited

Codecov Report

Merging #1910 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1910      +/-   ##
=============================================
- Coverage      55.39%   55.37%   -0.03%     
+ Complexity      2405     2404       -1     
=============================================
  Files            428      428              
  Lines          14349    14349              
  Branches        1697     1697              
=============================================
- Hits            7949     7946       -3     
- Misses          5684     5685       +1     
- Partials         716      718       +2
Impacted Files Coverage Δ Complexity Δ
.../io/seata/core/rpc/netty/v1/ProtocolV1Decoder.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../saga/statelang/domain/impl/AbstractTaskState.java 68.62% <ø> (ø) 18 <0> (ø) ⬇️
...a/saga/statelang/domain/impl/StateMachineImpl.java 58.49% <ø> (ø) 20 <0> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 57.59% <0%> (-0.95%) 29% <0%> (-1%)

@slievrly slievrly changed the title Optimize : All Override methods must be annotated with @override Optimize : all Override methods must be annotated with @override Nov 19, 2019
@slievrly slievrly changed the title Optimize : all Override methods must be annotated with @override optimize : all Override methods must be annotated with @override Nov 19, 2019
@slievrly slievrly changed the title optimize : all Override methods must be annotated with @override optimize : all override methods must be annotated with @override Nov 19, 2019
slievrly
slievrly approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly added the first-time contributor first-time contributor label Nov 19, 2019
zjinlei
zjinlei approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit c088ef0 into apache:develop Nov 19, 2019
@EZKAYOTWJPRKXWCUYEEB EZKAYOTWJPRKXWCUYEEB deleted the optimize_1 branch November 19, 2019 05:04
@slievrly slievrly added this to the 1.0 milestone Dec 2, 2019
@EZKAYOTWJPRKXWCUYEEB EZKAYOTWJPRKXWCUYEEB changed the title optimize : all override methods must be annotated with @override optimize : all override methods must be annotated with "@override" Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slievrly slievrly slievrly approved these changes

@zjinlei zjinlei zjinlei approved these changes

Assignees
No one assigned
Labels
first-time contributor first-time contributor
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@EZKAYOTWJPRKXWCUYEEB @codecov-io @slievrly @zjinlei