Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize : javadoc should be used for classes, class variables and methods. #1911

Merged
merged 5 commits into from
Nov 20, 2019

Conversation

EZKAYOTWJPRKXWCUYEEB
Copy link
Contributor

@EZKAYOTWJPRKXWCUYEEB EZKAYOTWJPRKXWCUYEEB commented Nov 19, 2019

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Nov 19, 2019

Codecov Report

Merging #1911 into develop will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1911      +/-   ##
=============================================
- Coverage      55.32%   55.29%   -0.04%     
+ Complexity      2401     2400       -1     
=============================================
  Files            428      428              
  Lines          14347    14347              
  Branches        1688     1688              
=============================================
- Hits            7938     7933       -5     
- Misses          5695     5697       +2     
- Partials         714      717       +3
Impacted Files Coverage Δ Complexity Δ
...java/io/seata/rm/datasource/ConnectionContext.java 60% <ø> (ø) 15 <0> (ø) ⬇️
...c/main/java/io/seata/server/store/StoreConfig.java 83.33% <ø> (ø) 5 <0> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 56.96% <0%> (-0.95%) 29% <0%> (ø)
...in/java/io/seata/server/session/GlobalSession.java 84.54% <0%> (-0.49%) 67% <0%> (-1%)
...o/seata/server/coordinator/DefaultCoordinator.java 48.01% <0%> (-0.4%) 28% <0%> (ø)

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@helloworlde helloworlde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 0eee716 into apache:develop Nov 20, 2019
@EZKAYOTWJPRKXWCUYEEB EZKAYOTWJPRKXWCUYEEB deleted the optimize_2 branch November 21, 2019 08:46
@slievrly slievrly added this to the 1.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants