-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize : javadoc should be used for classes, class variables and methods. #1911
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1911 +/- ##
=============================================
- Coverage 55.32% 55.29% -0.04%
+ Complexity 2401 2400 -1
=============================================
Files 428 428
Lines 14347 14347
Branches 1688 1688
=============================================
- Hits 7938 7933 -5
- Misses 5695 5697 +2
- Partials 714 717 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rm-datasource/src/main/java/io/seata/rm/datasource/ConnectionContext.java
Outdated
Show resolved
Hide resolved
specification javadoc
specification javadoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews