Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix : fix string.format() method formatting error #1912

Merged
merged 2 commits into from
Nov 22, 2019

Conversation

EZKAYOTWJPRKXWCUYEEB
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Nov 19, 2019

Codecov Report

Merging #1912 into develop will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1912      +/-   ##
=============================================
+ Coverage      55.24%   55.26%   +0.02%     
+ Complexity      2400     2399       -1     
=============================================
  Files            428      428              
  Lines          14219    14219              
  Branches        1664     1664              
=============================================
+ Hits            7855     7858       +3     
+ Misses          5659     5657       -2     
+ Partials         705      704       -1
Impacted Files Coverage Δ Complexity Δ
...ata/core/store/db/AbstractDataSourceGenerator.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 57.46% <0%> (+0.63%) 29% <0%> (-1%) ⬇️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 64.56% <0%> (+0.78%) 25% <0%> (ø) ⬇️

@EZKAYOTWJPRKXWCUYEEB EZKAYOTWJPRKXWCUYEEB changed the title optimize : complex expressions should not be used in conditions bugfix : fix string.format() method formatting error Nov 21, 2019
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zjinlei zjinlei merged commit 3efd6a2 into apache:develop Nov 22, 2019
@EZKAYOTWJPRKXWCUYEEB EZKAYOTWJPRKXWCUYEEB deleted the optimize_3 branch November 22, 2019 01:39
@slievrly slievrly added this to the 1.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants