bugfix: support where condition exists for Oracle #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1914 +/- ##
============================================
- Coverage 55.33% 55.3% -0.03%
+ Complexity 2405 2402 -3
============================================
Files 428 428
Lines 14361 14347 -14
Branches 1694 1688 -6
============================================
- Hits 7947 7935 -12
Misses 5697 5697
+ Partials 717 715 -2
|
l81893521
reviewed
Nov 20, 2019
| @@ -50,6 +57,20 @@ public BaseRecognizer(String originalSQL) { | |||
|
|
|||
| } | |||
|
|
|||
| public void excuteVisit(SQLExpr where, SQLASTVisitor visitor) { | |||
There was a problem hiding this comment.
Please change the name to executeVisit()
l81893521
approved these changes
Nov 20, 2019
There was a problem hiding this comment.
LGTM. Test passed.
Test Case
update account_tbl a set money = money - ?
where exists ( select 1 from order_tbl o where a.user_id = o.user_id and o.user = ?)
update account_tbl a set money = money - ?
where not exists ( select 1 from order_tbl o where a.user_id = o.user_id and o.user = ?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
support where condition exists for Oracle
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews