-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: NullPointerException in DB mock during CI #1917
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1917 +/- ##
=============================================
- Coverage 55.26% 55.23% -0.03%
+ Complexity 2401 2399 -2
=============================================
Files 428 428
Lines 14219 14219
Branches 1664 1664
=============================================
- Hits 7858 7854 -4
- Misses 5658 5660 +2
- Partials 703 705 +2
|
rm-datasource/src/test/java/io/seata/rm/datasource/mock/MockDriver.java
Outdated
Show resolved
Hide resolved
rm-datasource/src/test/java/io/seata/rm/datasource/mock/MockDriver.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Ⅰ. Describe what this PR did
When set the mock value null, would cause some NullPointerException during the CI.
Ⅱ. Does this pull request fix one issue?
#1916
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews