Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: NullPointerException in DB mock during CI #1917

Merged
merged 6 commits into from
Nov 21, 2019

Conversation

l81893521
Copy link
Contributor

Ⅰ. Describe what this PR did

When set the mock value null, would cause some NullPointerException during the CI.

Ⅱ. Does this pull request fix one issue?

#1916

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Nov 19, 2019

Codecov Report

Merging #1917 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1917      +/-   ##
=============================================
- Coverage      55.26%   55.23%   -0.03%     
+ Complexity      2401     2399       -2     
=============================================
  Files            428      428              
  Lines          14219    14219              
  Branches        1664     1664              
=============================================
- Hits            7858     7854       -4     
- Misses          5658     5660       +2     
- Partials         703      705       +2
Impacted Files Coverage Δ Complexity Δ
...ource/sql/struct/cache/AbstractTableMetaCache.java 85.29% <0%> (-5.89%) 11% <0%> (ø)
...in/java/io/seata/server/session/GlobalSession.java 84.54% <0%> (-0.49%) 67% <0%> (-1%)
...o/seata/server/coordinator/DefaultCoordinator.java 48.01% <0%> (-0.4%) 27% <0%> (-1%)

Copy link
Contributor

@helloworlde helloworlde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@slievrly slievrly merged commit 7576ca2 into apache:develop Nov 21, 2019
@l81893521 l81893521 deleted the fix_db_mock branch November 21, 2019 07:12
@slievrly slievrly added this to the 1.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants