Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize assert throw exception #1918

Merged
merged 3 commits into from
Nov 20, 2019
Merged

optimize: optimize assert throw exception #1918

merged 3 commits into from
Nov 20, 2019

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

optimize: optimize assert throw exception

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Nov 19, 2019

Codecov Report

Merging #1918 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1918   +/-   ##
==========================================
  Coverage      55.29%   55.29%           
  Complexity      2400     2400           
==========================================
  Files            428      428           
  Lines          14347    14347           
  Branches        1688     1688           
==========================================
  Hits            7933     7933           
+ Misses          5697     5696    -1     
- Partials         717      718    +1
Impacted Files Coverage Δ Complexity Δ
...server/store/file/FileTransactionStoreManager.java 56.64% <0%> (-0.32%) 29% <0%> (ø)
...java/io/seata/rm/datasource/ConnectionContext.java 60% <0%> (ø) 15% <0%> (ø) ⬇️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 64.56% <0%> (+0.78%) 25% <0%> (ø) ⬇️
...c/main/java/io/seata/server/store/StoreConfig.java 83.33% <0%> (ø) 5% <0%> (ø) ⬇️

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi merged commit 1204bc3 into apache:develop Nov 20, 2019
@slievrly slievrly added this to the 1.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants