Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: force check code style #1919

Merged
merged 17 commits into from
Nov 21, 2019
Merged

optimize: force check code style #1919

merged 17 commits into from
Nov 21, 2019

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

optimize: force checkstyle

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@slievrly slievrly changed the title optimize: force checkstyle optimize: force check code style Nov 19, 2019
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
@lovepoem
Copy link
Member

image
I think there is a global Format tool by clicking the right key menu of a project

Signed-off-by: slievrly <slievrly@163.com>
@slievrly
Copy link
Member Author

image
I think there is a global Format tool by clicking the right key menu of a project

checkstyle also check variable name, Chinese, and extra brackets.

@codecov-io
Copy link

codecov-io commented Nov 19, 2019

Codecov Report

Merging #1919 into develop will decrease coverage by 0.2%.
The diff coverage is 56.07%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #1919      +/-   ##
============================================
- Coverage       55.3%   55.1%   -0.21%     
+ Complexity      2401    2399       -2     
============================================
  Files            428     428              
  Lines          14347   14219     -128     
  Branches        1688    1636      -52     
============================================
- Hits            7935    7835     -100     
+ Misses          5697    5656      -41     
- Partials         715     728      +13
Impacted Files Coverage Δ Complexity Δ
...o/seata/core/exception/RmTransactionException.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...a/io/seata/saga/statelang/domain/StateMachine.java 85.71% <ø> (ø) 0 <0> (ø) ⬇️
.../io/seata/core/rpc/netty/v1/ProtocolV1Encoder.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../java/io/seata/core/store/GlobalTransactionDO.java 97.14% <ø> (ø) 23 <0> (ø) ⬇️
...ata/core/exception/BranchTransactionException.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ta/spring/annotation/GlobalTransactionScanner.java 50% <ø> (ø) 17 <0> (ø) ⬇️
...rm/datasource/sql/druid/MySQLInsertRecognizer.java 100% <ø> (ø) 15 <0> (ø) ⬇️
...a/rm/datasource/sql/druid/BaseMySQLRecognizer.java 90.9% <ø> (ø) 6 <0> (ø) ⬇️
...core/protocol/transaction/GlobalReportRequest.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ata/core/exception/GlobalTransactionException.java 0% <ø> (ø) 0 <0> (ø) ⬇️
... and 90 more

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Copy link
Member

@lovepoem lovepoem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsbxyyx jsbxyyx merged commit 48f475c into apache:develop Nov 21, 2019
@slievrly slievrly added this to the 1.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants