-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix duplicated table meta cache key #1929
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1929 +/- ##
=============================================
- Coverage 55.06% 55.04% -0.03%
- Complexity 2472 2474 +2
=============================================
Files 444 444
Lines 14758 14784 +26
Branches 1742 1746 +4
=============================================
+ Hits 8127 8138 +11
- Misses 5886 5901 +15
Partials 745 745
|
xingfudeshi
reviewed
Nov 23, 2019
rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/cache/MysqlTableMetaCache.java
Show resolved
Hide resolved
xingfudeshi
reviewed
Nov 23, 2019
rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/cache/MysqlTableMetaCache.java
Outdated
Show resolved
Hide resolved
xingfudeshi
reviewed
Nov 23, 2019
rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/cache/MysqlTableMetaCache.java
Outdated
Show resolved
Hide resolved
…epeated_cache_key
xingfudeshi
approved these changes
Nov 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
slievrly
reviewed
Nov 29, 2019
rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/cache/MysqlTableMetaCache.java
Show resolved
Hide resolved
…epeated_cache_key
slievrly
approved these changes
Dec 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
slievrly
changed the title
bugfix: Fix duplicated cache key
bugfix: fix duplicated cache key
Dec 12, 2019
zjinlei
changed the title
bugfix: fix duplicated cache key
bugfix: fix duplicated table meta cache key
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Fix duplicated cache key in table meta cache.
For mysql
For oracle
Ⅱ. Does this pull request fix one issue?
#1928
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews