Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix duplicated table meta cache key #1929

Merged
merged 24 commits into from
Dec 13, 2019

Conversation

l81893521
Copy link
Contributor

@l81893521 l81893521 commented Nov 22, 2019

Ⅰ. Describe what this PR did

Fix duplicated cache key in table meta cache.

For mysql

1.remove the single quote
2.Is case sensitive base on databaseMetaData.supportsMixedCaseIdentifiers().

For oracle

1.Is case sensitive base on double quote.
(because Oracle does not implement databaseMetaData.supportsMixedCaseIdentifiers())
2.remove the double quote.

Ⅱ. Does this pull request fix one issue?

#1928

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Nov 22, 2019

Codecov Report

Merging #1929 into develop will decrease coverage by 0.02%.
The diff coverage is 37.03%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1929      +/-   ##
=============================================
- Coverage      55.06%   55.04%   -0.03%     
- Complexity      2472     2474       +2     
=============================================
  Files            444      444              
  Lines          14758    14784      +26     
  Branches        1742     1746       +4     
=============================================
+ Hits            8127     8138      +11     
- Misses          5886     5901      +15     
  Partials         745      745
Impacted Files Coverage Δ Complexity Δ
...ource/sql/struct/cache/AbstractTableMetaCache.java 87.87% <ø> (-0.36%) 11 <0> (-1)
...asource/sql/struct/cache/OracleTableMetaCache.java 5.88% <0%> (-0.51%) 3 <0> (ø)
...tasource/sql/struct/cache/MysqlTableMetaCache.java 80.9% <52.63%> (-5.91%) 11 <2> (+1)
...o/seata/server/coordinator/DefaultCoordinator.java 48.41% <0%> (+0.39%) 28% <0%> (+1%) ⬆️
...in/java/io/seata/server/session/GlobalSession.java 85.02% <0%> (+0.48%) 68% <0%> (+1%) ⬆️

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zjinlei zjinlei added this to the 1.0 milestone Dec 12, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title bugfix: Fix duplicated cache key bugfix: fix duplicated cache key Dec 12, 2019
@zjinlei zjinlei merged commit 97dc589 into apache:develop Dec 13, 2019
@zjinlei zjinlei changed the title bugfix: fix duplicated cache key bugfix: fix duplicated table meta cache key Dec 13, 2019
@l81893521 l81893521 deleted the fix_repeated_cache_key branch May 8, 2020 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants