Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: reduce HashMap initial size #1930

Merged
merged 5 commits into from
Nov 23, 2019
Merged

optimize: reduce HashMap initial size #1930

merged 5 commits into from
Nov 23, 2019

Conversation

ruqinhu
Copy link
Contributor

@ruqinhu ruqinhu commented Nov 22, 2019

Ⅰ. Describe what this PR did

reduce HashMap initial size,It doesn't need size of 16.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Nov 22, 2019

Codecov Report

Merging #1930 into develop will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1930      +/-   ##
=============================================
+ Coverage      55.16%   55.17%   +<.01%     
  Complexity      2402     2402              
=============================================
  Files            429      429              
  Lines          14246    14246              
  Branches        1668     1668              
=============================================
+ Hits            7859     7860       +1     
  Misses          5679     5679              
+ Partials         708      707       -1
Impacted Files Coverage Δ Complexity Δ
...a/rm/tcc/interceptor/ActionInterceptorHandler.java 25.37% <0%> (ø) 7 <0> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 56.5% <0%> (+0.31%) 29% <0%> (ø) ⬇️

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi merged commit 151b8ea into apache:develop Nov 23, 2019
@slievrly slievrly added this to the 1.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants