Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: nacos-config.py support namespace #1931

Merged
merged 3 commits into from
Nov 23, 2019
Merged

feature: nacos-config.py support namespace #1931

merged 3 commits into from
Nov 23, 2019

Conversation

anrror
Copy link
Contributor

@anrror anrror commented Nov 22, 2019

Ⅰ. One of the requirements for Nacos's ‘namespace’ ;

Ⅱ. When we post the 'configs' of Nacos server , The parameters of ‘namespace‘ can be supported。

@codecov-io
Copy link

codecov-io commented Nov 22, 2019

Codecov Report

Merging #1931 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1931      +/-   ##
=============================================
+ Coverage      55.16%   55.19%   +0.02%     
  Complexity      2402     2402              
=============================================
  Files            429      429              
  Lines          14246    14246              
  Branches        1668     1668              
=============================================
+ Hits            7859     7863       +4     
+ Misses          5679     5677       -2     
+ Partials         708      706       -2
Impacted Files Coverage Δ Complexity Δ
...server/store/file/FileTransactionStoreManager.java 57.46% <0%> (+1.26%) 29% <0%> (ø) ⬇️

@slievrly
Copy link
Member

slievrly commented Nov 23, 2019

image

function test pass.

@slievrly slievrly changed the title seata/server/src/main/resources/nacos-config.py localhost namespace feature: nacos-config.py support namespace Nov 23, 2019
@slievrly
Copy link
Member

./nacos-config.py localhost $nacos-namespace-id

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi merged commit 9a407fd into apache:develop Nov 23, 2019
@slievrly slievrly added this to the 1.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants