optimize: some about rpc optimize. #1935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cServer init exception.
1.pull away from the handler, Follow a single principle of responsibility. 2.Reorganize dependencies. 3.RpcServerBootstrap. 4.(TODO)create processor to handle channelread() logic.
1.pull away from the handler, Follow a single principle of responsibility. 2.Reorganize dependencies. 3.RpcServerBootstrap. 4.(TODO)create processor to handle channelread() logic.
slievrly
reviewed
Nov 26, 2019
core/src/main/java/io/seata/core/rpc/netty/AbstractRpcRemotingClient.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #1935 +/- ##
=============================================
+ Coverage 53.64% 53.78% +0.14%
Complexity 2619 2619
=============================================
Files 491 491
Lines 15378 15382 +4
Branches 1729 1760 +31
=============================================
+ Hits 8249 8273 +24
- Misses 6322 6325 +3
+ Partials 807 784 -23
|
# Conflicts: # core/src/main/java/io/seata/core/rpc/DefaultServerMessageListenerImpl.java # core/src/main/java/io/seata/core/rpc/netty/AbstractRpcRemotingClient.java # core/src/main/java/io/seata/core/rpc/netty/AbstractRpcRemotingServer.java
|
@slievrly Conflict resolved. |
slievrly
reviewed
Feb 6, 2020
slievrly
approved these changes
Feb 6, 2020
booogu
pushed a commit
to booogu/seata
that referenced
this pull request
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
1.pull away from the handler, Follow a single principle of responsibility.
2.Reorganize dependencies.
3.create RpcServerBootstrap.
4.(TODO)create processor to handle channelread() logic.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews