Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize:optimize the speed when batch insert or batch update #1938

Conversation

caohdgege
Copy link
Contributor

@caohdgege caohdgege commented Nov 24, 2019

…image data and don't call pkRows in loop)

Ⅰ. Describe what this PR did

optimize the speed when batch insert or batch update

Ⅱ. Does this pull request fix one issue?

fixes #1933

Ⅲ. Describe how to verify it

compare the speed before merge and after merge when effect rows more than 10000

@xingfudeshi xingfudeshi added the first-time contributor first-time contributor label Nov 24, 2019
@codecov-io
Copy link

codecov-io commented Nov 24, 2019

Codecov Report

Merging #1938 into develop will decrease coverage by 0.04%.
The diff coverage is 71.42%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1938      +/-   ##
=============================================
- Coverage      55.22%   55.17%   -0.05%     
+ Complexity      2405     2402       -3     
=============================================
  Files            429      429              
  Lines          14246    14247       +1     
  Branches        1668     1668              
=============================================
- Hits            7867     7861       -6     
- Misses          5676     5679       +3     
- Partials         703      707       +4
Impacted Files Coverage Δ Complexity Δ
.../rm/datasource/exec/BaseTransactionalExecutor.java 43.58% <71.42%> (+0.48%) 18 <2> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 56.5% <0%> (-1.59%) 29% <0%> (-1%)
...in/java/io/seata/server/session/GlobalSession.java 84.54% <0%> (-0.49%) 67% <0%> (-1%)
...o/seata/server/coordinator/DefaultCoordinator.java 48.01% <0%> (-0.4%) 27% <0%> (-1%)

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly added the theme: performance An issue or pr that we don't feel is valid label Nov 24, 2019
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi changed the title optimize the speed when batch insert or batch update optimize:optimize the speed when batch insert or batch update Nov 25, 2019
@xingfudeshi xingfudeshi merged commit 41a1b35 into apache:develop Nov 25, 2019
@slievrly slievrly added this to the 1.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor theme: performance An issue or pr that we don't feel is valid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

批量更新的时候速度慢
5 participants