Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add using organization logo #1951

Merged
merged 22 commits into from
Nov 27, 2019
Merged

doc: add using organization logo #1951

merged 22 commits into from
Nov 27, 2019

Conversation

slievrly
Copy link
Member

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

doc: add using organization logo

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Nov 27, 2019

Codecov Report

Merging #1951 into develop will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1951      +/-   ##
=============================================
- Coverage      55.15%   55.11%   -0.05%     
+ Complexity      2404     2402       -2     
=============================================
  Files            429      429              
  Lines          14261    14261              
  Branches        1673     1673              
=============================================
- Hits            7866     7860       -6     
- Misses          5691     5693       +2     
- Partials         704      708       +4
Impacted Files Coverage Δ Complexity Δ
...server/store/file/FileTransactionStoreManager.java 56.19% <0%> (-1.27%) 29% <0%> (ø)
...in/java/io/seata/server/session/GlobalSession.java 84.54% <0%> (-0.49%) 67% <0%> (-1%)
...o/seata/server/coordinator/DefaultCoordinator.java 48.01% <0%> (-0.4%) 27% <0%> (-1%)

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
@lovepoem
Copy link
Member

lovepoem commented Nov 27, 2019

image

<div style='vertical-align: middle'>
<img src='https://camo.githubusercontent.com/b1477fe051d0f92c2431a606e05f4e3ae5b4ceba/68747470733a2f2f696d672e616c6963646e2e636f6d2f7466732f5442316a3064456f703637674b306a535a506658586168684658612d3430302d3230382e6a7067' height='40' alt='凯京科技'>
<img src="https://camo.githubusercontent.com/900dde1b2db61337f6b1b7099a4f9266c683682f/68747470733a2f2f7777772e6b616e6768656865616c74682e636f6d2f696d616765732f6c6f676f2e706e67" height ="40"  alt='康合上医'>
</div>

I think you can try like this

slievrly and others added 4 commits November 27, 2019 16:30
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Copy link
Member

@lovepoem lovepoem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lovepoem lovepoem merged commit 7d2d028 into apache:develop Nov 27, 2019
@slievrly slievrly added this to the 1.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants