Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: transform desinger json to statemachine standard json #1958

Merged

Conversation

long187
Copy link
Contributor

@long187 long187 commented Nov 29, 2019

Ⅰ. Describe what this PR did

We provided a Saga StateMachine Designer, State language json generated by the Designer has layout informations. We need transform it to standard Saga State language json.

Ⅱ. Does this pull request fix one issue?

#1948

Ⅳ. Describe how to verify it

run unit test at test/src/test/java/io/seata/saga/engine/StateMachineTests.java

Ⅴ. Special notes for reviews

The Json generated by the designer is different from the standard Json of the Saga state machine (because the json generated by the designer has layout information), This PR is In order to make the state machine can be directly loaded and it will be converted into the Json of the Saga state machine standard.

@codecov-io
Copy link

codecov-io commented Nov 29, 2019

Codecov Report

Merging #1958 into develop will increase coverage by 0.18%.
The diff coverage is 79.84%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1958      +/-   ##
=============================================
+ Coverage       55.3%   55.49%   +0.18%     
- Complexity      2409     2436      +27     
=============================================
  Files            429      430       +1     
  Lines          14278    14397     +119     
  Branches        1676     1707      +31     
=============================================
+ Hits            7897     7989      +92     
- Misses          5673     5682       +9     
- Partials         708      726      +18
Impacted Files Coverage Δ Complexity Δ
.../statelang/parser/impl/StateMachineParserImpl.java 72.5% <78.57%> (-5.28%) 8 <1> (+1)
...tatelang/parser/utils/DesignerJsonTransformer.java 80% <80%> (ø) 24 <24> (?)
...server/store/file/FileTransactionStoreManager.java 56.19% <0%> (-0.96%) 29% <0%> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 48.41% <0%> (+0.39%) 29% <0%> (+1%) ⬆️
...in/java/io/seata/server/session/GlobalSession.java 85.02% <0%> (+0.48%) 68% <0%> (+1%) ⬆️

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@long187 long187 changed the title transform desinger json to statemachine standard json feature: transform desinger json to statemachine standard json Nov 29, 2019
Copy link
Contributor

@zhangthen zhangthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants