Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Provide a visual graph designer for Seata Saga StateMachine based on GGEditor #1960

Merged
merged 2 commits into from
Dec 2, 2019

Conversation

long187
Copy link
Contributor

@long187 long187 commented Nov 29, 2019

Ⅰ. Describe what this PR did

Provide a visual graph designer for Seata Saga StateMachine based on GGEditor.

After using the designer to complete the design of the state machine, you can click the 'Json View' button on the toolbar to switch to the Json view, and save the Json to the project of your own application. Although the Json generated by the designer is different from the standard Json of the Saga state machine (because the json generated by the designer has layout information), the json can be directly loaded and it will be converted into the Json of the Saga state machine standard.

Ⅱ. Does this pull request fix one issue?

#1959

Ⅳ. Describe how to verify it

see saga/seata-saga-statemachine-designer/README.md

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Nov 29, 2019

Codecov Report

Merging #1960 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1960   +/-   ##
==========================================
  Coverage      55.28%   55.28%           
  Complexity      2408     2408           
==========================================
  Files            429      429           
  Lines          14278    14278           
  Branches        1676     1676           
==========================================
  Hits            7894     7894           
  Misses          5675     5675           
  Partials         709      709

@long187 long187 changed the title Saga: Private a visual graph designer for Seata Saga StateMachine based on GGEditor Saga: Provide a visual graph designer for Seata Saga StateMachine based on GGEditor Nov 29, 2019
@long187 long187 changed the title Saga: Provide a visual graph designer for Seata Saga StateMachine based on GGEditor feature: Provide a visual graph designer for Seata Saga StateMachine based on GGEditor Nov 29, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhangthen zhangthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@long187 long187 merged commit ebfd03c into apache:develop Dec 2, 2019
@slievrly slievrly added this to the 1.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants