feature: add single send request for client. #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1966 +/- ##
=============================================
- Coverage 55.3% 55.27% -0.03%
- Complexity 2522 2526 +4
=============================================
Files 446 446
Lines 14913 14927 +14
Branches 1766 1770 +4
=============================================
+ Hits 8247 8251 +4
- Misses 5901 5911 +10
Partials 765 765
|
…p-single-send # Conflicts: # core/src/main/java/io/seata/core/rpc/netty/AbstractRpcRemoting.java
slievrly
reviewed
Dec 2, 2019
zjinlei
reviewed
Dec 2, 2019
core/src/main/java/io/seata/core/rpc/netty/NettyClientConfig.java
Outdated
Show resolved
Hide resolved
|
already added |
slievrly
reviewed
Dec 3, 2019
core/src/main/java/io/seata/core/rpc/netty/AbstractRpcRemoting.java
Outdated
Show resolved
Hide resolved
…nto nacos-config.txt
l81893521
reviewed
Dec 18, 2019
core/src/main/java/io/seata/core/rpc/netty/AbstractRpcRemotingClient.java
Show resolved
Hide resolved
|
I think should add the config to file.conf.example and RpcMessage.toString() add the type of Message just like MergeResultMessage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
add single send request for client.
add 'transport.enable-client-batch-send-request' config param.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews