Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile #1967

Merged
merged 12 commits into from
Dec 13, 2019
Merged

Add Dockerfile #1967

merged 12 commits into from
Dec 13, 2019

Conversation

niaoshuai
Copy link
Contributor

Ⅰ. Describe what this PR did

Add Dockerfile

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Dec 1, 2019

Codecov Report

Merging #1967 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1967   +/-   ##
==========================================
  Coverage      55.08%   55.08%           
- Complexity      2472     2474    +2     
==========================================
  Files            444      444           
  Lines          14758    14758           
  Branches        1742     1742           
==========================================
  Hits            8129     8129           
- Misses          5885     5886    +1     
+ Partials         744      743    -1
Impacted Files Coverage Δ Complexity Δ
...server/store/file/FileTransactionStoreManager.java 56.5% <0%> (-0.96%) 29% <0%> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 48.41% <0%> (+0.39%) 28% <0%> (+1%) ⬆️
...in/java/io/seata/server/session/GlobalSession.java 85.02% <0%> (+0.48%) 68% <0%> (+1%) ⬆️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 63.7% <0%> (+0.8%) 24% <0%> (ø) ⬇️

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

distribution/Dockerfile Outdated Show resolved Hide resolved
distribution/Dockerfile Outdated Show resolved Hide resolved
distribution/Dockerfile Outdated Show resolved Hide resolved
@zjinlei zjinlei added this to the 1.0 milestone Dec 8, 2019
distribution/Dockerfile Outdated Show resolved Hide resolved
distribution/Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@helloworlde helloworlde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 441c039 into apache:develop Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants