Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fixed error of get server port in container #1973

Merged
merged 1 commit into from
Dec 2, 2019
Merged

bugfix: fixed error of get server port in container #1973

merged 1 commit into from
Dec 2, 2019

Conversation

helloworlde
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Dec 2, 2019

Codecov Report

Merging #1973 into develop will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1973      +/-   ##
=============================================
- Coverage      55.29%   55.24%   -0.05%     
+ Complexity      2433     2431       -2     
=============================================
  Files            431      431              
  Lines          14442    14442              
  Branches        1708     1708              
=============================================
- Hits            7985     7979       -6     
- Misses          5733     5736       +3     
- Partials         724      727       +3
Impacted Files Coverage Δ Complexity Δ
...src/main/java/io/seata/server/ParameterParser.java 46.8% <0%> (ø) 11 <0> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 56.5% <0%> (-0.96%) 29% <0%> (ø)
...very/registry/zk/ZookeeperRegisterServiceImpl.java 63.77% <0%> (-0.79%) 25% <0%> (ø)
...in/java/io/seata/server/session/GlobalSession.java 84.54% <0%> (-0.49%) 67% <0%> (-1%)
...o/seata/server/coordinator/DefaultCoordinator.java 48.01% <0%> (-0.4%) 27% <0%> (-1%)

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi merged commit 6bca531 into apache:develop Dec 2, 2019
@slievrly slievrly added this to the 1.0 milestone Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants