Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: Flatten Saga nested transactions #1975

Merged
merged 4 commits into from
Dec 11, 2019

Conversation

long187
Copy link
Contributor

@long187 long187 commented Dec 2, 2019

Ⅰ. Describe what this PR did

Saga nested transaction(SubState Machine)will create a new Global transaction, it is not necessary, We need make it Flatten.

Ⅱ. Does this pull request fix one issue?

#1974

Ⅳ. Describe how to verify it

run unit test at seata/test/src/test/java/io/seata/saga

@codecov-io
Copy link

codecov-io commented Dec 2, 2019

Codecov Report

Merging #1975 into develop will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1975      +/-   ##
=============================================
+ Coverage      55.31%   55.32%   +<.01%     
+ Complexity      2439     2437       -2     
=============================================
  Files            434      434              
  Lines          14469    14470       +1     
  Branches        1706     1707       +1     
=============================================
+ Hits            8004     8005       +1     
+ Misses          5743     5742       -1     
- Partials         722      723       +1
Impacted Files Coverage Δ Complexity Δ
...o/seata/saga/statelang/domain/DomainConstants.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../statelang/parser/impl/StateMachineParserImpl.java 70.73% <0%> (-1.77%) 8 <0> (ø)
...in/java/io/seata/server/session/GlobalSession.java 84.54% <0%> (-0.49%) 67% <0%> (-1%)
...o/seata/server/coordinator/DefaultCoordinator.java 48.01% <0%> (-0.4%) 27% <0%> (-1%)
...server/store/file/FileTransactionStoreManager.java 57.46% <0%> (+0.95%) 29% <0%> (ø) ⬇️

@long187 long187 changed the title Flatten Saga nested transactions optimize: Flatten Saga nested transactions Dec 2, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zjinlei
zjinlei previously approved these changes Dec 10, 2019
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 0358df5 into apache:develop Dec 11, 2019
@wangliang181230 wangliang181230 added this to the 1.0.0 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants