Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: FileTransactionStoreManagerTest failed on wins OS #1978

Merged
merged 3 commits into from
Dec 3, 2019
Merged

bugfix: FileTransactionStoreManagerTest failed on wins OS #1978

merged 3 commits into from
Dec 3, 2019

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Dec 3, 2019

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

fix FileTransactionStoreManagerTest failed on wins OS

Ⅱ. Does this pull request fix one issue?

fixes #1937

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Dec 3, 2019

Codecov Report

Merging #1978 into develop will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1978      +/-   ##
=============================================
+ Coverage      55.13%   55.28%   +0.15%     
+ Complexity      2432     2430       -2     
=============================================
  Files            432      432              
  Lines          14422    14439      +17     
  Branches        1669     1706      +37     
=============================================
+ Hits            7951     7983      +32     
- Misses          5727     5733       +6     
+ Partials         744      723      -21
Impacted Files Coverage Δ Complexity Δ
...in/java/io/seata/server/session/GlobalSession.java 84.54% <0%> (-1.11%) 67% <0%> (-1%)
...o/seata/server/coordinator/DefaultCoordinator.java 48.01% <0%> (-0.4%) 27% <0%> (-1%)
...java/io/seata/spring/tcc/TccActionInterceptor.java 12.5% <0%> (-0.33%) 2% <0%> (ø)
...n/java/io/seata/rm/datasource/ConnectionProxy.java 25.83% <0%> (-0.22%) 12% <0%> (ø)
...a/io/seata/core/rpc/netty/AbstractRpcRemoting.java 9.64% <0%> (-0.2%) 3% <0%> (ø)
...in/java/io/seata/server/session/BranchSession.java 80.45% <0%> (-0.02%) 44% <0%> (ø)
...va/io/seata/core/store/db/LogStoreDataBaseDAO.java 55.44% <0%> (+0.14%) 21% <0%> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 57.46% <0%> (+0.31%) 29% <0%> (ø) ⬇️
...buf/convertor/BranchRollbackResponseConvertor.java 100% <0%> (+2.94%) 3% <0%> (ø) ⬇️
...tobuf/convertor/BranchCommitResponseConvertor.java 100% <0%> (+3.03%) 3% <0%> (ø) ⬇️
... and 19 more

Signed-off-by: slievrly <slievrly@163.com>
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed. LGTM

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
MAC OS also Test passed.

@zjinlei zjinlei merged commit c48cdc4 into apache:develop Dec 3, 2019
@wangliang181230 wangliang181230 added this to the 1.0.0 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileTransactionStoreManager is never close so the seataFile could not be delete
5 participants