Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize get select for update recognizer #1979

Merged
merged 2 commits into from
Dec 3, 2019

Conversation

l81893521
Copy link
Contributor

Ⅰ. Describe what this PR did

When I use PG Sql in the feature branch, I found could not use one way to determine the SQL is for update or not. So, we have to use different way for different database.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Dec 3, 2019

Codecov Report

Merging #1979 into develop will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1979      +/-   ##
=============================================
- Coverage      55.29%   55.26%   -0.03%     
+ Complexity      2432     2430       -2     
=============================================
  Files            432      432              
  Lines          14436    14439       +3     
  Branches        1707     1706       -1     
=============================================
- Hits            7982     7980       -2     
- Misses          5733     5735       +2     
- Partials         721      724       +3
Impacted Files Coverage Δ Complexity Δ
...source/sql/druid/MySqlOperateRecognizerHolder.java 100% <100%> (ø) 7 <2> (+1) ⬆️
...ql/druid/oracle/OracleOperateRecognizerHolder.java 100% <100%> (ø) 7 <2> (+1) ⬆️
.../io/seata/rm/datasource/sql/SQLVisitorFactory.java 82.35% <100%> (-0.99%) 5 <0> (-1)
...server/store/file/FileTransactionStoreManager.java 56.5% <0%> (-0.96%) 29% <0%> (ø)
...in/java/io/seata/server/session/GlobalSession.java 84.54% <0%> (-0.49%) 67% <0%> (-1%)
...o/seata/server/coordinator/DefaultCoordinator.java 48.01% <0%> (-0.4%) 27% <0%> (-2%)

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit cbc53fc into apache:develop Dec 3, 2019
@l81893521 l81893521 deleted the optimize_recognizer branch May 6, 2020 01:18
@wangliang181230 wangliang181230 added this to the 1.0.0 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants