optimize:show the applicationId when register TM #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1980 +/- ##
============================================
- Coverage 55.31% 55.3% -0.02%
+ Complexity 2439 2437 -2
============================================
Files 434 434
Lines 14469 14469
Branches 1706 1706
============================================
- Hits 8004 8002 -2
Misses 5743 5743
- Partials 722 724 +2
|
slievrly
reviewed
Dec 10, 2019
| @@ -133,8 +133,8 @@ public void onRegTmMessage(RpcMessage request, ChannelHandlerContext ctx, Server | |||
| Version.putChannelVersion(ctx.channel(), message.getVersion()); | |||
| isSuccess = true; | |||
| if (LOGGER.isInfoEnabled()) { | |||
| LOGGER.info(String.format("checkAuth for client:%s vgroup:%s ok", ipAndPort, | |||
| message.getTransactionServiceGroup())); | |||
| LOGGER.info("checkAuth for client:{},vgroup:{},applicationId:{}", | |||
There was a problem hiding this comment.
Here you need a status to indicate that it is authenticated OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
optimize:show the applicationId when register TM
when register TM,we do not know which application register,we just know the ip and port like this:
io.seata.core.rpc.DefaultServerMessageListenerImpl.onRegTmMessage:133 -checkAuth for client:192.168.xx.xx:10984 vgroup:fsp_tx_group okWhen we monitor the server log，it is very unfriendly,we want to know which application had regiested,or remove，like this:
io.seata.core.rpc.DefaultServerMessageListenerImpl.onRegTmMessage:133 -checkAuth for client:192.168.xx.xx:10984 vgroup:fsp_tx_group applicationId:user-server okⅡ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews