Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfxi: fixed issue of presuppose environment variable and replace base image for tool #1984

Merged
merged 4 commits into from
Dec 6, 2019
Merged

Conversation

helloworlde
Copy link
Contributor

Ⅰ. Describe what this PR did

  1. Removed presuppose environment variable
  2. Replace base image of JDK8
  3. Add JVM args for respect CPU and RAM limits

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Dec 3, 2019

Codecov Report

Merging #1984 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1984      +/-   ##
=============================================
+ Coverage      55.26%   55.28%   +0.02%     
- Complexity      2430     2432       +2     
=============================================
  Files            432      432              
  Lines          14439    14439              
  Branches        1706     1706              
=============================================
+ Hits            7979     7982       +3     
  Misses          5735     5735              
+ Partials         725      722       -3
Impacted Files Coverage Δ Complexity Δ
...o/seata/server/coordinator/DefaultCoordinator.java 48.41% <0%> (+0.39%) 28% <0%> (ø) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 85.02% <0%> (+0.48%) 68% <0%> (+1%) ⬆️
...ource/sql/struct/cache/AbstractTableMetaCache.java 88.23% <0%> (+2.94%) 12% <0%> (+1%) ⬆️

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xingfudeshi xingfudeshi merged commit 1e5ce50 into apache:develop Dec 6, 2019
@helloworlde helloworlde deleted the develop_up branch May 31, 2020 09:00
@slievrly slievrly added this to the 1.3.0 milestone Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants