Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: add netty config constant keys. #1990

Merged
merged 2 commits into from
Dec 8, 2019

Conversation

objcoding
Copy link
Contributor

Ⅰ. Describe what this PR did

add netty config constant keys.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Dec 4, 2019

Codecov Report

Merging #1990 into develop will decrease coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1990      +/-   ##
=============================================
- Coverage      55.28%   55.27%   -0.01%     
+ Complexity      2432     2430       -2     
=============================================
  Files            432      432              
  Lines          14439    14439              
  Branches        1706     1706              
=============================================
- Hits            7982     7981       -1     
+ Misses          5735     5734       -1     
- Partials         722      724       +2
Impacted Files Coverage Δ Complexity Δ
...ava/io/seata/core/constants/ConfigurationKeys.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ava/io/seata/core/rpc/netty/NettyServerConfig.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ava/io/seata/core/rpc/netty/NettyClientConfig.java 45.31% <100%> (ø) 22 <3> (ø) ⬇️
.../java/io/seata/core/rpc/netty/NettyBaseConfig.java 36.11% <100%> (ø) 2 <0> (ø) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 84.54% <0%> (-0.49%) 67% <0%> (-1%)
...o/seata/server/coordinator/DefaultCoordinator.java 48.01% <0%> (-0.4%) 27% <0%> (-1%)
...very/registry/zk/ZookeeperRegisterServiceImpl.java 63.7% <0%> (+0.8%) 24% <0%> (ø) ⬇️

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zjinlei zjinlei merged commit 81c4efe into apache:develop Dec 8, 2019
@wangliang181230 wangliang181230 added this to the 1.0.0 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants