Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature:support dynamic disable #1992

Merged
merged 23 commits into from
Dec 13, 2019
Merged

feature:support dynamic disable #1992

merged 23 commits into from
Dec 13, 2019

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Dec 5, 2019

Ⅰ. Describe what this PR did

feature:support dynamic disable

  1. If disable = true at startup, the runtime will always be disabled and cannot be changed dynamically;
  2. If disable = false at startup, it can be changed at runtime

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

slievrly and others added 17 commits November 13, 2019 18:49
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Dec 5, 2019

Codecov Report

Merging #1992 into develop will decrease coverage by 0.01%.
The diff coverage is 21.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #1992      +/-   ##
============================================
- Coverage      55.02%     55%   -0.02%     
  Complexity      2472    2472              
============================================
  Files            444     444              
  Lines          14784   14793       +9     
  Branches        1746    1746              
============================================
+ Hits            8135    8137       +2     
- Misses          5902    5908       +6     
- Partials         747     748       +1
Impacted Files Coverage Δ Complexity Δ
...ava/io/seata/core/constants/ConfigurationKeys.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...c/main/java/io/seata/config/FileConfiguration.java 40.9% <0%> (-0.76%) 6 <1> (ø)
...ing/annotation/GlobalTransactionalInterceptor.java 10% <10%> (+0.47%) 2 <0> (ø) ⬇️
...ta/spring/annotation/GlobalTransactionScanner.java 48.67% <100%> (ø) 17 <1> (ø) ⬇️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 63.7% <0%> (+0.8%) 24% <0%> (ø) ⬇️

@zjinlei zjinlei added this to the 1.0 milestone Dec 8, 2019
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@objcoding
Copy link
Contributor

file LGTM.

@anrror
Copy link
Contributor

anrror commented Dec 13, 2019

LGTM

@zjinlei
Copy link
Contributor

zjinlei commented Dec 13, 2019

@anrror Please note the configuration center you verified successfully.

@objcoding
Copy link
Contributor

apollo LGTM.

@objcoding
Copy link
Contributor

zk LGTM.

@objcoding
Copy link
Contributor

consul LGTM.

@objcoding
Copy link
Contributor

etcd3 LGTM.

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nacos test well.
LGTM

@zjinlei zjinlei merged commit 0162771 into apache:develop Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants